Skip to content

Develop [Refactoring]#21

Merged
schatty merged 17 commits intomasterfrom
develop
Jul 17, 2025
Merged

Develop [Refactoring]#21
schatty merged 17 commits intomasterfrom
develop

Conversation

@schatty
Copy link
Owner

@schatty schatty commented Jul 17, 2025

  • Dataclasses, Pydantic Settings, Type Annotations, Protocols
  • Files restructuring to more flat repo structure
  • Refined configs
  • MyPy Support
  • Tests Coverage > 90%
  • uv, ruff support
  • SafetyGymnasium support alongside dm_control and gymnasium

schatty added 15 commits June 24, 2025 20:24
* Add tests for safety gymnasium

* Install SafetyGymnasium into Dockerfile

* Change tests coverage in CI

* Fix typo
* Move configs from package and refine

* Replace inheritance with composition for trainer, make visualization script

* Refactor replay buffer

* Refactor environment module

* Add new environment files

* Remove utils folder

* Make trainers dataclasses

* Add option for storing logs outside src folder, make logs dir creation common code

* Introduce explicit protocols

* Introduce base algorithm with explore and exploit functionality

* Ensure algo and buffer has been created in trainer

* Add proper stdout logging instead of bare prints

* Make algos configurable

* Replace bare dict with pydantic config in configs

* Refine annotations

* Make distrib code work

* Refactor distrib training

* Add explicit gymnasium support

* Fix: gymnasium support

* Add uv ruff

* Add uv to dockerfile and ci

* Add tests

* Add mypy check for custom modules

* Add ruff to ci pipeline

* Fix in ci

* Fix ci

* Fix mypy typo in ci

* Add missing module file

* Exclude runners

* Update README.md
@schatty schatty self-assigned this Jul 17, 2025
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 89.27336% with 62 lines in your changes missing coverage. Please review.

Project coverage is 91.92%. Comparing base (e5b0113) to head (4661895).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/oprl/buffers/episodic_buffer.py 60.25% 31 Missing ⚠️
src/oprl/environment/protocols.py 63.63% 8 Missing ⚠️
src/oprl/algos/nn_models.py 87.50% 5 Missing ⚠️
src/oprl/environment/dm_control.py 89.79% 5 Missing ⚠️
src/oprl/algos/base_algorithm.py 66.66% 3 Missing ⚠️
src/oprl/environment/gymnasium.py 89.28% 3 Missing ⚠️
src/oprl/environment/safety_gymnasium.py 89.65% 3 Missing ⚠️
src/oprl/logging.py 97.10% 2 Missing ⚠️
src/oprl/algos/protocols.py 95.00% 1 Missing ⚠️
src/oprl/environment/make_env.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   85.85%   91.92%   +6.07%     
==========================================
  Files           8       17       +9     
  Lines         594      793     +199     
==========================================
+ Hits          510      729     +219     
+ Misses         84       64      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@schatty schatty merged commit 90a533c into master Jul 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant