fix: make TrustedDeviceTokenStorage conform to ResetInterface #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt-thomas-durand
force-pushed
the
trusted-device-reset
branch
2 times, most recently
from
9c37f5f to
c674b19
Compare
In certain scenarios, TrustedDeviceTokenStorage might not be re-instanciated between requests. That's the case when multiple requests are handled by a single worker, like when serving the application with RoadRunner or with FrankenPHP. In that case, the trusted_device cookie leak from a request to another, and break the feature entirely. By implementing ResetInterface, the storage is now properly reseted between requests
dt-thomas-durand
force-pushed
the
trusted-device-reset
branch
from
c674b19 to
0e6cbce
Compare
dt-thomas-durand
changed the title
dt-boris-castagna
approved these changes
Mar 21, 2025
Owner
|
Yes, we could add this. Two things that we need to change:
|
Contributor
Author
Thanks for your feedback. |
Added it to the bundle for maintainability reasons. I'll be easier to upgrade Symfony if all Symfony dependencies lies in the bundle
Owner
|
Perfect, thank you very much! Released as v7.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In certain scenarios, TrustedDeviceTokenStorage might not be re-instanciated between requests. That's the case when multiple requests are handled by a single worker, like when serving the application with RoadRunner or with FrankenPHP. In that case, the trusted_device cookie leak from a request to another, and break the feature entirely. By implementing ResetInterface, the storage is now properly reseted between requests