Skip to content

fix(ci): correct matrix strategy and bump action versions to v4#272

Closed
Copilot wants to merge 2 commits intopythons/angular-21-upgradefrom
copilot/sub-pr-270-again
Closed

fix(ci): correct matrix strategy and bump action versions to v4#272
Copilot wants to merge 2 commits intopythons/angular-21-upgradefrom
copilot/sub-pr-270-again

Conversation

Copy link
Contributor

Copilot AI commented Mar 11, 2026

The CI workflow had a broken matrix strategy — node-version was set to a scalar string instead of an array, and setup-node hardcoded the version rather than referencing ${{ matrix.node-version }}, making the matrix entirely ineffective.

Changes

  • Matrix format: node-version: '24.13.0'node-version: ['24.13.0']
  • Matrix variable usage: node-version: '24.13.0'node-version: ${{ matrix.node-version }} in the setup-node step
  • Action versions: actions/checkout@v3 + actions/setup-node@v3@v4, consistent with npm-publish.yml
# Before
strategy:
  matrix:
    node-version: '24.13.0'   # scalar, not an array
...
      - uses: actions/checkout@v3
        uses: actions/setup-node@v3
        with:
          node-version: '24.13.0'  # ignores matrix entirely

# After
strategy:
  matrix:
    node-version: ['24.13.0']
...
      - uses: actions/checkout@v4
        uses: actions/setup-node@v4
        with:
          node-version: ${{ matrix.node-version }}

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…rsions to v4

Co-authored-by: so-kaushal <28099586+so-kaushal@users.noreply.github.com>
Copilot AI changed the title [WIP] Update to address feedback on python/angular 21 upgrade fix(ci): correct matrix strategy and bump action versions to v4 Mar 11, 2026
@so-kaushal so-kaushal closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants