Fix one-dark-pro theme loading hang and font style errors #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace problematic useAsyncMemo with robust useThemeHighlighter hook - Add 8-second timeout for theme loading to prevent infinite hangs - Implement automatic fallback to github-dark when one-dark-pro fails - Add proper error handling and cleanup for theme loading requests - Enhance loading UI to show which theme is being loaded - Add error state display with reload option when theme loading fails This resolves the infinite spinner issue where one-dark-pro theme would get stuck while github-dark worked fine. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fix font style validation to prevent "Required value missing" errors - Add shikiji dependency to plugin package for TypeScript types - Improve getFontStyles function with proper fallbacks for missing font variants - Add validation check before applying font styles to prevent runtime errors Resolves issues where: 1. one-dark-pro theme would get stuck with spinning "run plugin" 2. Font style errors when Bold/Italic variants are not available 3. Plugin would hang indefinitely when theme loading failed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Add installCommand and buildCommand to vercel.json - Ensures Vercel uses pnpm instead of npm for dependency installation - Fixes deployment failures caused by package manager mismatch
|
@ash-uxi is attempting to deploy a commit to the Schickling Personal Team on Vercel. A member of the Team first needs to authorize it. |
Vercel Deployment UpdateThe previous Vercel deployment failure has been resolved by adding proper pnpm configuration to The current authorization error indicates that the Vercel deployment now requires authorization from the repository owner (@schickling) to deploy from this fork. Changes in this PR:
The core fixes are ready for review and testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two critical issues affecting plugin stability:
Changes Made
Theme Loading Improvements
Font Style Fixes
getFontStylesfunction with proper fallbacks for missing font variantsTest Plan
Before/After
Before: Plugin would hang indefinitely on one-dark-pro theme and crash with font style errors
After: Robust theme loading with automatic fallback and graceful handling of missing font variants