Merged
Conversation
school year bounds.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the school year bounds calculation in the Bakalari integration by replacing hardcoded school year start dates with a dynamic calculation using the new school_year_bounds utility function.
Changes:
- Replaced hardcoded
datetime(year=today.year, month=10, day=1).date()with dynamicschool_year_bounds(today)function call - Updated import statement to include the new
school_year_boundsutility function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
NoticeboardandMessagesto fetch messages from correct school year bounds.