Fixed issue when cached schools will hang initialization.#98
Merged
Conversation
Owner
schizza
commented
Jan 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug where the initialization process would hang when schools were loaded from cache. The original code incorrectly returned False even when schools were successfully loaded from cache, preventing the configuration flow from completing.
Changes:
- Fixed
_load_schools()to properly returnTruewhen schools are loaded from cache - Added error tracking and retry mechanism for failed school loading attempts
- Added exception handling for unexpected errors during school loading
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| custom_components/bakalari/translations/cs.json | Added "unknown" error message translation for unexpected errors |
| custom_components/bakalari/config_flow.py | Fixed critical bug where cache-loaded schools returned False instead of True; added error tracking, retry mechanism, and proper task completion checking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.