Skip to content

Conversation

@sjednac
Copy link
Contributor

@sjednac sjednac commented Sep 7, 2025

I've tested the whole process, including the guided GitHub app setup, on my personal account. There were two minor issues, that I needed to fix for the Docker environment to work:

  • The process needs to bind to 0.0.0.0 when run inside Docker. Otherwise, port forwarding won't work.
  • The argument of the Docker command should take credentials location as an absolute path inside
    Docker, as the CWD is set to /data.

Now it works like a charm! 🎉 I will test it on an actual org account in the following week.

The process needs to bind to `0.0.0.0` when run inside Docker.
Otherwise, port forwarding won't work.
The argument should take credentials location as an absolute path inside
Docker, as the CWD is set to /data.
@schlomo schlomo requested a review from Copilot September 7, 2025 11:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Docker environment configuration issues for the GitHub backup app by addressing network binding and path resolution problems.

  • Adds a configurable host binding option to support Docker port forwarding
  • Updates Docker command documentation to use absolute paths for credential files

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
github_backup/create_github_app.py Adds --host parameter and updates server binding to use configurable host
README.md Updates Docker command examples to bind to 0.0.0.0 and use absolute credential paths

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@schlomo schlomo merged commit c662485 into schlomo:main Sep 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants