Add a way to avoid throwing Exceptions #324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bburnichon
force-pushed
the
feature/avoid-throwing-exceptions
branch
from
d80563b to
667a141
Compare
| public function visitPhpFile(\SplFileInfo $file, MessageCatalogue $catalogue, array $ast) { } | ||
| } | ||
|
|
||
| public function setLogger(LoggerInterface $logger) |
Collaborator
|
Thank you for this PR. I really like the idea of removing that ugly FIXME. But I believe we should do it on a case-by-case basis instead of just logging the error if a logger exists. Also, I would like to see some tests to this PR. |
bburnichon
force-pushed
the
feature/avoid-throwing-exceptions
branch
from
657a498 to
9710dec
Compare
Contributor
Author
|
@Nyholm rebased and restored ugly FIXME comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, there are ways to continue extraction as soon as an invalid Node is encountered. This PR does not throw exception if a logger is present.
Todos