Skip to content

Conversation

@benjamin-hubert
Copy link
Collaborator

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets
License MIT

Description

We are using the XLIFF dumper made in JMSTranslationBundle with the extractor.
We should be using the XliffFileDumper from Symfony for all the default extraction.

Todos

  • Tests
  • Documentation
  • Changelog

@Nyholm
Copy link
Collaborator

Nyholm commented Apr 7, 2016

This will get a 👎 from me. It is a BC break since we remove the metadata about where the translations exists. That metadata is however only used in the WebUI and I understand that many users do not use the WebUI at all but as long as the WebUI is a part of this bundle we should not merge this PR.

A discussion about splitting the bundle into smaller parts is started here: #283

@Nyholm
Copy link
Collaborator

Nyholm commented Apr 9, 2016

We should of course make this optional by the bundle's configuration. That way we let the user to choose the dumper. If we do not alter the default behavior, Im happy to merge a change like this.

jms_translation:
  dumper: 'service_id_for_a_dumper'

There is one more issue to solve (I think). It's how we use different dumpers for different filetypes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants