Skip to content

Conversation

@evertharmeling
Copy link

see #437

@gnat42
Copy link
Collaborator

gnat42 commented Aug 8, 2017

This looks like a slam dunk - I'm wondering 2 things however.

  • Can you include as part of this a test case that fails when this isn't applied
  • Do you know what instance $item->value would need to be to have getDocComment? We could still hit the same issue if we call that method and it isn't an instance of whatever it needs to be to have that method? Or is it guaranteed to have that method?
    If you can do those two things I'd be happy to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants