Do not change types during deseralization#1578
Merged
scyzoryck merged 3 commits intoschmittjoh:masterfrom Apr 1, 2025
Merged
Conversation
scyzoryck
force-pushed
the
union-serialization
branch
from
70b76e9 to
734f769
Compare
added 3 commits
April 1, 2025 21:03
# Conflicts: # tests/Serializer/JsonSerializationTest.php
scyzoryck
force-pushed
the
union-serialization
branch
from
469f74c to
7867d8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's make tests more strict, as
self::assertEquals(1, true);is true... 🤡It shows the change of thet type during serialization.
During deserialization - if the type is possible for the property - let's keep it. If not possible - let's try to guess.