Add default class for discriminator by vsychov #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan1986
force-pushed
the
default-discriminator-renew
branch
2 times, most recently
from
de48774 to
1b4303a
Compare
scyzoryck
reviewed
Jul 29, 2025
ivan1986
force-pushed
the
default-discriminator-renew
branch
from
1b4303a to
127250c
Compare
scyzoryck
reviewed
Jul 29, 2025
scyzoryck
reviewed
Jul 30, 2025
Collaborator
|
Beside one comment the code looks good for me. |
Co-authored-by: Marcin Czarnecki <[email protected]>
Co-authored-by: Marcin Czarnecki <[email protected]>
ivan1986
force-pushed
the
default-discriminator-renew
branch
from
2d92540 to
14ab966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is update of #707 for latest version