suppress duplicate reports with -c/-C and -q/-Q#392
Merged
auerswal merged 1 commit intoschweikert:developfrom Jul 18, 2025
Merged
suppress duplicate reports with -c/-C and -q/-Q#392auerswal merged 1 commit intoschweikert:developfrom
auerswal merged 1 commit intoschweikert:developfrom
Conversation
Collaborator
Author
|
I have created this as a draft, because I am not sure if there was a reason to treat loop mode and count mode differently regarding duplicate reporting. |
Collaborator
Author
|
Any reasons against aligning duplicate report suppression in count mode with that of loop mode? |
gsnw-sebast
approved these changes
Jul 12, 2025
Collaborator
gsnw-sebast
left a comment
gsnw-sebast
left a comment
There was a problem hiding this comment.
From my point of view, we can take it from there.
If fping receives a duplicate Echo Reply packet, it reports this. This report was suppressed for loop mode, and for other operating modes where each receive event is reported. Now, this duplicate report is also suppressed when in count mode with options -q, --quiet or -Q, --squiet. This addresses GitHub issue schweikert#389.
Collaborator
Author
|
While rebasing, I noticed that I had introduced blank lines between changelog items in a block. This was inconsistent with older changelog entries, so I removed those blank lines while solving the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If fping receives a duplicate Echo Reply packet, it reports this. This report was suppressed for loop mode, and for other operating modes where each receive event is reported. Now, this duplicate report is also suppressed when in count mode with options -q, --quiet or -Q, --squiet.
This addresses GitHub issue #389.