Print receive ping moved to new functions#400
Merged
gsnw-sebast merged 1 commit intoschweikert:developfrom Aug 25, 2025
Merged
Conversation
auerswal
requested changes
Aug 2, 2025
Collaborator
auerswal
left a comment
auerswal
left a comment
There was a problem hiding this comment.
I think it would be better if you could move the computations outside of the print functions. They are currently duplicated, and just moving the code into additional functions keeps them duplicated. Ideally, moving printing to additional functions should reduce code duplication.
gsnw-sebast
force-pushed
the
print_recv
branch
3 times, most recently
from
7bdc64b to
959c7ed
Compare
schweikert
approved these changes
Aug 23, 2025
gsnw-sebast
force-pushed
the
print_recv
branch
from
959c7ed to
cee468b
Compare
gsnw-sebast
changed the title
gsnw-sebast
force-pushed
the
print_recv
branch
from
cee468b to
613a5b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have split the output below the function
int wait_for_reply(int64_t wait_time)into four new functions.This should make it easier to read.