better Netbsd compatibility #452
Conversation
Testing string equality using "test" is done with the "=" operator. Bash also accepts "==", but this is not portable. The issue was noticed on NetBSD, which uses a patch to the generated "configure" script[1]. [1] https://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/net/fping/patches/patch-configure?rev=1.3;content-type=text%2Fplain
NetBSD does not know the IP_RECVTOS socket option. Thus conditionally compile setting this option only when it is defined. This is the same change as used in the NetBSD package[1], with thanks to "adam". [1] https://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/net/fping/patches/patch-src_fping.c?rev=1.5;content-type=text%2Fplain
Summary of ChangesHello @auerswal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves NetBSD compatibility by applying two targeted patches. The change in configure.ac to use = instead of == for string comparison in a test command enhances shell script portability. The modification in src/fping.c correctly wraps the usage of the IP_RECVTOS socket option within an #if defined(IP_RECVTOS) block, as this option is not available on NetBSD. These changes are well-implemented and directly address the compatibility issue. The code is clean and I have no suggestions for improvement.
3 participants
Improve portability to NetBSD by adapting two patches from the NetBSD package https://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/net/fping/. This addresses GH issue #450.