-
Notifications
You must be signed in to change notification settings - Fork 28
Fix the rendering of shortcuts with branch bundles, and improve shortcut header performance #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stefanv
merged 14 commits into
scientific-python:main
from
agriyakhetarpal:fix/shortcuts-for-branch-bundles
Mar 18, 2025
+35
−15
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
30464cc
Fix the rendering of shortcuts with branch bundles
agriyakhetarpal baa71d4
Simplify `shortcutsContainer` check
agriyakhetarpal 98d6c02
Fix linter error
agriyakhetarpal f0370a3
Add comment about class selector construction
agriyakhetarpal 5f298bc
Wrap contents with a `content-wrapper`
agriyakhetarpal f26c503
Update content wrapper + container selectors
agriyakhetarpal 7187b2e
Drop `content-wrapper` divs, keep wrapper divs
agriyakhetarpal 112d2da
Add a child div for leaf bundles
agriyakhetarpal a098cf2
Drop selector for `content-wrapper`
agriyakhetarpal 4636a52
Actually, drop extra divs altogether
agriyakhetarpal ef7bf8f
Handle headers within tabpanels
agriyakhetarpal 88aa751
Revert "Handle headers within tabpanels"
agriyakhetarpal 0bf458b
Add back `:not([role='tabpanel'])` with a catch
agriyakhetarpal 343cb67
Remove tabpanel again
stefanv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,15 +98,24 @@ function setupShortcuts(shortcutDepth = 2) { | |
|
|
||
| shortcutDepth += 1; // to account for the page title | ||
|
|
||
| // Build a class selector for each header type, and concatenate with commas | ||
| /* | ||
| * We have build selectors to find headers in different contexts. | ||
| * i. direct children of .content-container (main structure) | ||
| * i. headers within tabpanels (for tabbed content) | ||
|
||
| */ | ||
| let classes = ""; | ||
|
|
||
| for (let i = 2; i <= shortcutDepth; i++) { | ||
| if (i != 2) { | ||
| classes += ","; | ||
| } | ||
| classes += " .content-container > h" + i; | ||
| } | ||
|
|
||
| for (let i = 2; i <= shortcutDepth; i++) { | ||
agriyakhetarpal marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| classes += ", [role='tabpanel'] > h" + i; | ||
| } | ||
|
|
||
| const classElements = Array.from(document.querySelectorAll(classes)); | ||
|
|
||
| // Only proceed if we found headers (to avoid creating an empty shortcuts section) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.