Skip to content

Get markdown working on browse pages, homepage should still use snippet #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2024
Merged

Get markdown working on browse pages, homepage should still use snippet #206

merged 2 commits into from
Feb 2, 2024

Conversation

summer-cook
Copy link
Contributor

@summer-cook summer-cook commented Feb 2, 2024 •
edited
Loading

Related

Expected Behavior Before Changes

  • As a user, I would not see markdown in descriptions on the browse page that contain markdown

Expected Behavior After Changes

  • As a user, i will see markdown in descriptions on the browse page that contain markdown
  • As a user, I will see snippets on the featured service page, and descriptions on the browse/search page.

Screenshots / Video

Browse page will use description with markdown Video: https://share.zight.com/o0uOqZx2 image
Featured services will still use snippet image

@summer-cook summer-cook mentioned this pull request Feb 2, 2024
Merged
alishaevn
alishaevn reviewed Feb 2, 2024
View reviewed changes
@alishaevn alishaevn merged commit 8fda119 into main Feb 2, 2024
@alishaevn alishaevn linked an issue Feb 2, 2024 that may be closed by this pull request
Add markdown to descriptions #205
Closed
@alishaevn alishaevn deleted the render-markdown branch February 27, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@alishaevn alishaevn alishaevn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Cap:Webstore patch-ver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add markdown to descriptions
3 participants
@summer-cook @alishaevn @cpetersen