Skip to content

Iphenovista72 add url to logo #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2024
Merged

Iphenovista72 add url to logo #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b6e14c
Adds ability to set URL for logo
labradford May 10, 2024
624ccd5
add trailing comma
labradford May 10, 2024
58adf9f
add logoUrl to header props
labradford May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/compounds/Header/Header.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ import Logo from '../Logo/Logo'
import './styles.scss'

const Header = ({ auth, linkColor, logo, navLinks, userSession }) => {
const { src, alt } = logo
const { src, alt, logoUrl } = logo

return (
<Navbar bg='primary' expand='md'>
<Container>
<Navbar.Brand className='w-50 custom-navbar-brand'>
<Logo src={src} alt={alt} height='auto' addClass='mw-100 mh-100' />
<Logo src={src} alt={alt} logoUrl={logoUrl} height='auto' addClass='mw-100 mh-100' />
</Navbar.Brand>
<Navbar.Toggle aria-controls='basic-navbar-nav'>
<ToggleIcon linkColor={linkColor} />
Expand Down
6 changes: 4 additions & 2 deletions src/compounds/Logo/Logo.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import React from 'react'
import PropTypes from 'prop-types'
import Image from '../../components/Image/Image'

const Logo = ({ addClass, alt, src, height }) => (
<a href='/'>
const Logo = ({ addClass, alt, src, height, logoUrl }) => (
<a href={logoUrl}>
<Image src={src} alt={alt} height={height} addClass={addClass} />
</a>
)
Expand All @@ -13,12 +13,14 @@ Logo.propTypes = {
alt: PropTypes.string,
src: PropTypes.string.isRequired,
height: PropTypes.number,
logoUrl: PropTypes.string,
}

Logo.defaultProps = {
addClass: '',
alt: '',
height: 50,
logoUrl: '/',
}

export default Logo
Loading