Skip to content

fix: Stop processing on error using FATAL_ERROR instead of SEND_ERROR #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix: Stop processing on error using FATAL_ERROR instead of SEND_ERROR #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cython_cmake/cmake/FindCython.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,13 @@ if(CYTHON_EXECUTABLE)
if(NOT ${CYTHON_version_result} EQUAL 0)
set(_error_msg "Command \"${CYTHON_version_command}\" failed with")
set(_error_msg "${_error_msg} output:\n${CYTHON_version_error}")
message(SEND_ERROR "${_error_msg}")
message(FATAL_ERROR "${_error_msg}")
elseif("${CYTHON_version_output}" MATCHES "^[Cc]ython version ([^,]+)")
set(CYTHON_VERSION "${CMAKE_MATCH_1}")
elseif("${CYTHON_version_error}" MATCHES "^[Cc]ython version ([^,]+)")
set(CYTHON_VERSION "${CMAKE_MATCH_1}")
else()
message(SEND_ERROR "Invalid Cython version output")
message(FATAL_ERROR "Invalid Cython version output")
endif()
endif()

Expand Down
2 changes: 1 addition & 1 deletion src/cython_cmake/cmake/UseCython.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
#=============================================================================

if(CMAKE_VERSION VERSION_LESS "3.7")
message(SEND_ERROR "CMake 3.7 required for DEPFILE")
message(FATAL_ERROR "CMake 3.7 required for DEPFILE")
endif()

function(Cython_compile_pyx)
Expand Down