feat: use a submodule for ninja sources #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeut
force-pushed
the
embedded-sources
branch
2 times, most recently
from
0ef77fc to
0292c7e
Compare
mayeut
force-pushed
the
embedded-sources
branch
from
0292c7e to
c0b9203
Compare
Contributor
|
Should we trim anything from the SDist? Usually there are docs and stuff we don't have to include. |
mayeut
force-pushed
the
embedded-sources
branch
from
b765656 to
b25f0f4
Compare
Contributor
Author
Most of the savings come from not included the png image in this repo (100kB). |
mayeut
force-pushed
the
embedded-sources
branch
2 times, most recently
from
cfe572c to
0341156
Compare
SDist goes from ~350kB to ~200kB
mayeut
force-pushed
the
embedded-sources
branch
from
0341156 to
66bec94
Compare
henryiii
approved these changes
Mar 20, 2025
jcfr
added a commit
to jcfr/ninja-python-distributions
that referenced
this pull request
Jun 19, 2025
Following 7a70669 ("feat: use a submodule for ninja sources (scikit-build#278)", 2025-03-20), attempting to fetch sources is superfluous.
jcfr
added a commit
to jcfr/ninja-python-distributions
that referenced
this pull request
Jun 19, 2025
…bdirectory Following 7a70669 ("feat: use a submodule for ninja sources (scikit-build#278)", 2025-03-20), attempting to fetch sources is not required as sources are already expected to be available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ninja Python distribution only needs sources from upstream (no need to download pre-built binaries from upstream).
Including upstream sources removes the need to download those sources when installing from an SDist.
fix #127