Use lief for macos as well

Signed-off-by: Cristian Le <[email protected]>

Author: LecrisUT

pyproject.toml

@@ -68,8 +68,7 @@ test-hatchling = [
 test-meta = [
     "hatch-fancy-pypi-readme>=22.3",
     "setuptools-scm",
-    "lief; platform_system=='Linux'",
-    "delocate; platform_system=='Darwin'",
+    "lief; platform_system=='Linux' or platform_system=='Darwin'",
 ]
 test-numpy = [
     "numpy; python_version<'3.14' and platform_python_implementation!='PyPy' and (platform_system != 'Windows' or platform_machine != 'ARM64')",
@@ -191,7 +190,6 @@ module = [
     "setuptools_scm",
     "hatch_fancy_pypi_readme",
     "virtualenv",
-    "delocate.*",
     "lief.*",
 ]
 ignore_missing_imports = true

src/scikit_build_core/builder/get_requires.py

@@ -148,10 +148,8 @@ def other_dynamic_requires(self) -> Generator[str, None, None]:
 
         if self.settings.wheel.repair.enable:
             platform_system = platform.system()
-            if platform_system == "Linux":
+            if platform_system in ("Linux", "Darwin"):
                 yield "lief"
-            elif platform_system == "Darwin":
-                yield "delocate"
 
     def dynamic_metadata(self) -> Generator[str, None, None]:
         if self.settings.fail:

src/scikit_build_core/repair_wheel/darwin.py

@@ -29,16 +29,28 @@ class MacOSWheelRepairer(RpathWheelRepairer):
     _origin_symbol = "@loader_path"
 
     def get_library_rpath(self, artifact: Path) -> list[str]:
-        from delocate.tools import get_rpaths
-
-        # Using the deprecated method here in order to support python 3.8
-        return list(get_rpaths(str(artifact)))
+        import lief.MachO
+
+        rpaths = []
+        fat_macho = lief.MachO.parse(artifact)
+        for macho_it in range(fat_macho.size):
+            macho = fat_macho.at(macho_it)
+            if not macho.has_rpath:
+                continue
+            for macho_rpath in macho.rpaths:
+                rpaths.extend(macho_rpath.path)
+        return rpaths
 
     def patch_library_rpath(self, artifact: Path, rpaths: list[str]) -> None:
-        from delocate.tools import _delete_rpaths, add_rpath
-
-        original_rpaths = self.get_library_rpath(artifact)
-        _delete_rpaths(str(artifact), set(original_rpaths))
         final_rpaths = set(rpaths)
-        for rpath in final_rpaths:
-            add_rpath(str(artifact), rpath)
+        if final_rpaths:
+            import lief.MachO
+
+            fat_macho = lief.MachO.parse(artifact)
+            for macho_it in range(fat_macho.size):
+                macho = fat_macho.at(macho_it)
+                macho.remove(lief.MachO.LoadCommand.TYPE.RPATH)
+                for rpath in final_rpaths:
+                    macho_rpath = lief.MachO.RPathCommand.create(rpath)
+                    macho.add(macho_rpath)
+            fat_macho.write(str(artifact))

tests/conftest.py

@@ -54,10 +54,8 @@ def pep518_wheelhouse(tmp_path_factory: pytest.TempPathFactory) -> Path:
         "virtualenv",
         "wheel",
     ]
-    if platform.system() == "Linux":
+    if platform.system() in ("Linux", "Darwin"):
         packages.append("lief")
-    if platform.system() == "Darwin":
-        packages.append("delocate")
 
     if importlib.util.find_spec("cmake") is not None:
         packages.append("cmake")

tests/test_repair_wheel.py

@@ -45,10 +45,8 @@ def test_full_build(
 
     if not with_isolation:
         isolated.install("scikit-build-core")
-        if platform.system() == "Linux":
+        if platform.system() in ("Linux", "Darwin"):
             isolated.install("lief")
-        if platform.system() == "Darwin":
-            isolated.install("delocate")
         isolated.install("./extern", isolated=with_isolation)
 
     if backend == "pip":