Skip to content

chore: show platform info #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025
Merged

chore: show platform info #1094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/scikit_build_core/build/wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

import dataclasses
import os
import platform
import shutil
import sys
import sysconfig
import tempfile
from collections.abc import Mapping
Expand Down Expand Up @@ -259,6 +261,12 @@ def _build_wheel_impl_impl(
*cmake_msg,
f"{{red}}({state})",
)
logger.info(
"Implementation: {} {} on {}",
sys.implementation.name,
sys.platform,
platform.machine(),
)

with tempfile.TemporaryDirectory() as tmpdir:
build_tmp_folder = Path(tmpdir)
Expand Down
4 changes: 2 additions & 2 deletions src/scikit_build_core/settings/skbuild_overrides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from ..errors import CMakeNotFoundError
from ..resources import resources

__all__ = ["process_overides", "regex_match"]
__all__ = ["process_overrides", "regex_match"]


def __dir__() -> list[str]:
Expand Down Expand Up @@ -257,7 +257,7 @@ def inherit_join(
raise TypeError(msg)


def process_overides(
def process_overrides(
tool_skb: dict[str, Any],
*,
state: Literal["sdist", "wheel", "editable", "metadata_wheel", "metadata_editable"],
Expand Down
6 changes: 3 additions & 3 deletions src/scikit_build_core/settings/skbuild_read_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from .auto_cmake_version import find_min_cmake_version
from .auto_requires import get_min_requires
from .skbuild_model import CMakeSettings, NinjaSettings, ScikitBuildSettings
from .skbuild_overrides import process_overides
from .skbuild_overrides import process_overrides
from .sources import ConfSource, EnvSource, SourceChain, TOMLSource

if TYPE_CHECKING:
Expand Down Expand Up @@ -151,7 +151,7 @@

# Handle overrides
pyproject = copy.deepcopy(pyproject)
self.overrides = process_overides(
self.overrides = process_overrides(
pyproject.get("tool", {}).get("scikit-build", {}),
state=state,
env=env,
Expand Down Expand Up @@ -188,7 +188,7 @@

if extra_settings is not None:
extra_skb = copy.deepcopy(dict(extra_settings))
process_overides(extra_skb, state=state, env=env, retry=retry)
process_overrides(extra_skb, state=state, env=env, retry=retry)

Check warning on line 191 in src/scikit_build_core/settings/skbuild_read_settings.py

View check run for this annotation

Codecov / codecov/patch

src/scikit_build_core/settings/skbuild_read_settings.py#L191 

Added line #L191 was not covered by tests
toml_srcs.insert(0, TOMLSource(settings=extra_skb))

prefixed = {
Expand Down