Skip to content

ci: avoid Windows 3.13.4, warn #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

ci: avoid Windows 3.13.4, warn #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
# Python 3.13.4 broken on Windows
check-latest: >-
${{ matrix.python-version == '3.13' && runner.os == 'Windows' }}

- uses: astral-sh/setup-uv@v6
if: matrix.python-version != 'pypy-3.8'
Expand Down
11 changes: 11 additions & 0 deletions src/scikit_build_core/builder/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,17 @@ def configure(
python_include_dir = get_python_include_dir()
numpy_include_dir = get_numpy_include_dir()

# Warning for CPython 3.13.4 Windows bug
if (
sys.implementation.name == "CPython"
and sys.version_info[:3] == (3, 13, 4)
and sys.platform.startswith("win32")
and not sysconfig.get_config_var("Py_GIL_DISABLED")
): # pragma: nocover
logger.warning(
"Python 3.13.4 on Windows is broken for building, 3.13.5 was rushed out to fix it. Use an older, newer, or free-threaded version instead."
)

# Classic Find Python
cache_config["PYTHON_EXECUTABLE"] = Path(sys.executable)
cache_config["PYTHON_INCLUDE_DIR"] = python_include_dir
Expand Down
Loading