Skip to content

chore(deps): update pre-commit hooks #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2025
Merged

chore(deps): update pre-commit hooks #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1ea7e9
chore(deps): update pre-commit hooks
pre-commit-ci[bot] Jan 7, 2025
81ec5a4
style: fix mypy issue
henryiii Jan 10, 2025
f2d8ade
tests: fix for setuptools 75.8
henryiii Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ repos:
exclude: "^tests"

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.8.1
rev: v0.8.6
hooks:
- id: ruff
args: ["--fix", "--show-fixes"]
Expand All @@ -51,15 +51,15 @@ repos:
exclude: ^src/scikit_build_core/resources/find_python

- repo: https://github.com/rbubley/mirrors-prettier
rev: "v3.4.1"
rev: "v3.4.2"
hooks:
- id: prettier
types_or: [yaml, markdown, html, css, scss, javascript, json]
args: [--prose-wrap=always]
exclude: "^tests|src/scikit_build_core/resources/scikit-build.schema.json|^docs/projects.md"

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.13.0
rev: v1.14.1
hooks:
- id: mypy
exclude: |
Expand Down
2 changes: 1 addition & 1 deletion tests/test_cmake_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def generator(
else:
monkeypatch.setenv("CMAKE_GENERATOR", request.param)

return request.param
return request.param # type: ignore[no-any-return]


def configure_args(
Expand Down
3 changes: 2 additions & 1 deletion tests/test_setuptools_pep517.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,15 @@
def test_pep517_sdist():
correct_metadata = textwrap.dedent(
"""\
Metadata-Version: 2.1
Name: cmake-example
Version: 0.0.1
Requires-Python: >=3.7
Provides-Extra: test
"""
# TODO: why is this missing?
# Requires-Dist: pytest>=6.0; extra == "test"
# This was removed in https://github.com/pypa/setuptools/pull/4698 as part of 2.2 support:
# Metadata-Version: 2.1
)
metadata_set = set(correct_metadata.strip().splitlines())

Expand Down
Loading