refactor: add a format module that is used in the expansion of pyproject.toml
#998
Conversation
|
I think it could be a simple function that returns a (typed) dict? Putting it in one place is a good idea though. |
|
If we're ok with a function input with a lot of kwargs, then yeah it will have the same interface with less boilerplate. I was thinking if it was possible to save it somewhere, but each component needed is calculated somewhere noncentral, like the wheel tags. |
|
I was hoping to include |
|
@LecrisUT There's a community meeting currently if you'd like to join. |
Have a central location to view and evaluate all format variables used in the evaluation of the `pyproject.toml` Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
|
|
||
| ```{eval-rst} | ||
| .. autoattribute:: scikit_build_core.format.PyprojectFormatter.build_type | ||
| :no-index: |
There was a problem hiding this comment.
I would like to generate this section, but maybe in a later PR
| @@ -0,0 +1,27 @@ | |||
| # Formattable fields | |||
|
|
|||
| The following configure keys are formatted as Python f-strings: | |||
There was a problem hiding this comment.
Not good at naming these.
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
changed the title
format module that is used in the expansion of pyproject.tomlformat module that is used in the expansion of pyproject.toml
2 participants
Related to #992 formatter, I think it would be good to have a common place where to define all the format variables. Not sure on the implementation though if it should be a
TypedDict, simpleMappingwrapper or anything else.