Skip to content

Conversation

@ikrommyd
Copy link
Collaborator

Closes #3723

I think is_non_string_like_iterable is not enough here. It should also not be a dictionary cause dictionary is iterable.
However, dicts I think should be wrapped into a single-element list like line 1864 does right below.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.71%. Comparing base (b749e49) to head (69cf156).
⚠️ Report is 467 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/awkward/highlevel.py 78.30% <100.00%> (+1.63%) ⬆️

... and 199 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3728

@ikrommyd ikrommyd changed the title fix: ak.Record creation with nested dicts fix: ak.Record creation from iterable with nested dicts Nov 13, 2025
Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikrommyd - thanks for jumping in. Let’s discuss this at the next meeting. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ak.Record rejects nested dicts with scalar leaves

2 participants