Skip to content

fix: catch more sample merging edge cases#560

Open
alexander-held wants to merge 1 commit intomasterfrom
fix/sample-merge-duplicates
Open

fix: catch more sample merging edge cases#560
alexander-held wants to merge 1 commit intomasterfrom
fix/sample-merge-duplicates

Conversation

@alexander-held
Copy link
Copy Markdown
Member

Catch a few more edge cases: sample to be merged does not exist (providing a better error message), new sample has same name as existing unmerged sample leading to duplicate sample names (e.g. ["S", "B"] updated with {"S": ["B"]} resulting in ["S", "S"].

to-do: tests

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.81%. Comparing base (0252dee) to head (8517e12).

Files with missing lines Patch % Lines
src/cabinetry/model_utils.py 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #560      +/-   ##
===========================================
- Coverage   100.00%   99.81%   -0.19%     
===========================================
  Files           22       22              
  Lines         2132     2136       +4     
  Branches       300      302       +2     
===========================================
  Hits          2132     2132              
- Misses           0        2       +2     
- Partials         0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexander-held alexander-held force-pushed the fix/sample-merge-duplicates branch from 5685d74 to 8517e12 Compare March 25, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant