fix: catch more sample merging edge cases#560
Open
alexander-held wants to merge 1 commit intomasterfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
===========================================
- Coverage 100.00% 99.81% -0.19%
===========================================
Files 22 22
Lines 2132 2136 +4
Branches 300 302 +2
===========================================
Hits 2132 2132
- Misses 0 2 +2
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5685d74 to
8517e12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch a few more edge cases: sample to be merged does not exist (providing a better error message), new sample has same name as existing unmerged sample leading to duplicate sample names (e.g.
["S", "B"]updated with{"S": ["B"]}resulting in["S", "S"].to-do: tests