fix: address matplotlib typing issues and remove unnecessary casts#561
Merged
alexander-held merged 8 commits intomasterfrom Mar 25, 2026
Merged
fix: address matplotlib typing issues and remove unnecessary casts#561alexander-held merged 8 commits intomasterfrom
alexander-held merged 8 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #561 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2132 2132
Branches 300 300
=========================================
Hits 2132 2132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MoAly98
reviewed
Mar 20, 2026
MoAly98
reviewed
Mar 20, 2026
MoAly98
reviewed
Mar 20, 2026
MoAly98
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
matplotlibto themypydependencies and fix all typing-related issues withmatplotlib. There is one new# type: ignorefor which I found no better solution. A fewcastinstances are also no longer needed, so removing those. Additionally, set two more optionalmypyconfiguration options on the way towards strict mode: enabletype-argand disableimplicit-reexport.Following this, the only remaining things flagged by
mypy --strictare of kindwarn_return_any.