Skip to content

fix: address matplotlib typing issues and remove unnecessary casts#561

Merged
alexander-held merged 8 commits intomasterfrom
fix/typing-matplotlib
Mar 25, 2026
Merged

fix: address matplotlib typing issues and remove unnecessary casts#561
alexander-held merged 8 commits intomasterfrom
fix/typing-matplotlib

Conversation

@alexander-held
Copy link
Copy Markdown
Member

@alexander-held alexander-held commented Mar 16, 2026

Add matplotlib to the mypy dependencies and fix all typing-related issues with matplotlib. There is one new # type: ignore for which I found no better solution. A few cast instances are also no longer needed, so removing those. Additionally, set two more optional mypy configuration options on the way towards strict mode: enable type-arg and disable implicit-reexport.

Following this, the only remaining things flagged by mypy --strict are of kind warn_return_any.

* add matplotlib to mypy dependencies
* fix matplotlib typing issues
* enable type-arg and disable implicit_reexport for mypy
* remove superfluous instances of cast()

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d5e3a14) to head (ac9a136).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #561   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2132      2132           
  Branches       300       300           
=========================================
  Hits          2132      2132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexander-held alexander-held requested a review from MoAly98 March 16, 2026 18:42
@alexander-held alexander-held merged commit 72e59dd into master Mar 25, 2026
8 checks passed
@alexander-held alexander-held deleted the fix/typing-matplotlib branch March 25, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants