Skip to content

test: add missing asserts and fix mock return types#564

Merged
alexander-held merged 2 commits intomasterfrom
test/assert-and-mock
Mar 25, 2026
Merged

test: add missing asserts and fix mock return types#564
alexander-held merged 2 commits intomasterfrom
test/assert-and-mock

Conversation

@alexander-held
Copy link
Copy Markdown
Member

Fixing two things spotted in tests: the significance integration test was missing some asserts and the return types in a workspace building test should be dicts (but since this is all mocked, the test does not really change).

* add missing asserts to integration test
* fix return type of mock in workspace builder test

@alexander-held alexander-held requested a review from MoAly98 March 25, 2026 14:41
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (72e59dd) to head (34c0ac8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #564   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2132      2132           
  Branches       300       300           
=========================================
  Hits          2132      2132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexander-held alexander-held merged commit fcbc49e into master Mar 25, 2026
8 checks passed
@alexander-held alexander-held deleted the test/assert-and-mock branch March 25, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants