Skip to content

feat: add CorrT1METJet to NanoAOD schema and also add zero TrigObj mass #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat: add CorrT1METJet to NanoAOD schema and also add zero TrigObj mass #1480

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa09021
add CorrT1METJet to nanoaod and add zero trigobj mass
ikrommyd Nov 17, 2025
a42c4e8
make tracing work with form changes?
ikrommyd Nov 18, 2025
dee0526
Merge branch 'master' into ikrommyd/add-corrt1metjet
ikrommyd Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/coffea/nanoevents/schemas/nanoaod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ class NanoAODSchema(BaseSchema):
"IsoTrack": "PtEtaPhiMCollection",
"SoftActivityJet": "PtEtaPhiMCollection",
"TrigObj": "PtEtaPhiMCollection",
"CorrT1METJet": "PtEtaPhiMCollection",
# True lorentz: pt, eta, phi, mass
"FatJet": "FatJet",
"GenDressedLepton": "PtEtaPhiMCollection",
Expand Down Expand Up @@ -314,6 +315,22 @@ def _build_collections(self, field_names, input_contents):
if "Photon_energy" in branch_forms:
branch_forms["Photon_regrEnergy"] = branch_forms.pop("Photon_energy")

# Alias CorrT1METJet_rawPt to CorrT1METJet_pt and add zero mass for CorrT1METJet collection
if "oCorrT1METJet" in branch_forms:
if "CorrT1METJet_pt" not in branch_forms:
branch_forms["CorrT1METJet_pt"] = branch_forms["CorrT1METJet_rawPt"]
if "CorrT1METJet_mass" not in branch_forms:
branch_forms["CorrT1METJet_mass"] = transforms.zeros_from_offsets_form(
branch_forms["oCorrT1METJet"]
)

# Add zero mass to the trigger objects
if "oTrigObj" in branch_forms:
if "TrigObj_mass" not in branch_forms:
branch_forms["TrigObj_mass"] = transforms.zeros_from_offsets_form(
branch_forms["oTrigObj"]
)
Comment on lines +318 to +332
Copy link
Collaborator Author

@ikrommyd ikrommyd Nov 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these explicit stuff will be refactored in the form of class variable dictionaries similar to how we define all the other mixins. It will be done as part of closing #1474. I'm just now doing it in the same pattern as everything else.


output = {}
for name in collections:
mixin = self.mixins.get(name, "NanoCollection")
Expand Down
Loading