docs: tested/supported MCEGs and drop Python 3.8 support#298
docs: tested/supported MCEGs and drop Python 3.8 support#298
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 94.84% 94.86% +0.01%
==========================================
Files 2 2
Lines 330 331 +1
Branches 69 61 -8
==========================================
+ Hits 313 314 +1
Misses 10 10
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the testing infrastructure to use the latest scikit-hep-testdata (0.5.5), expands LHE reader tests to cover additional generators, and adjusts documentation and CI to match the new Python requirement.
- Bump Python requirement to >=3.9 and scikit-hep-testdata to >=0.5.5
- Add test fixtures for MadGraph, Pythia, Sherpa, and Whizard LHE outputs
- Update README with supported generator versions and drop Python 3.8 from CI
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_lhe_reader.py | Added new TEST_FILES lists for various generators and broadened parametrized tests |
| src/pylhe/init.py | Changed Iterable import to collections.abc.Iterable |
| pyproject.toml | Require Python >=3.9, bump scikit-hep-testdata to >=0.5.5, remove 3.8 classifier |
| README.md | Documented tested Monte Carlo generators and their versions |
| .github/workflows/ci.yml | Removed Python 3.8 from CI matrix |
Comments suppressed due to low confidence (2)
tests/test_lhe_reader.py:181
- [nitpick] The test function name
test_read_lhe_with_attributes_powhegno longer matches its broadened scope. Rename it to something liketest_read_lhe_with_attributes_generatorto reflect that it covers all generators.
def test_read_lhe_with_attributes_powheg(file):
README.md:25
- The version
5-2.0.0for MadGraph5 seems to include an extra5-prefix. It should likely read2.0.0to match the actual tested version.
| [MadGraph5](https://launchpad.net/mg5amcnlo) | 5-2.0.0, 2.2.1, 3.5.8 |
|
@all-contributors please add @APN-Pucky for documentation, maintenance. |
|
I've put up a pull request to add @APN-Pucky! 🎉 |
eduardo-rodrigues
left a comment
There was a problem hiding this comment.
Hi. This is really nice to see. Thank you!
Let's see if @matthewfeickert can also have a look but otherwise do not wait longer than today and merge.
Co-authored-by: Eduardo Rodrigues <eduardo.rodrigues@cern.ch>
|
Before I merge it I will remove the python3.8 check on the branch protection rule as required check. |
|
... and add 3.13 as required. |
Closes: #291