feat: add test data from RNTuple Viewer#174
Conversation
Adding test data root files from rntviewer: https://codeberg.org/silverweed/rntviewer
|
Hello. Let me ping @ariostas as he has been dealing a lot with this package ... A couple of things to have in mind:
|
|
@sathabbott there's already quite a few RNTuples in here. Do you need anything in specific that is missing, or is it mainly since they are "standard" test files used somewhere else? If it's the latter, maybe it would be good to at least add a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
=======================================
Coverage 72.38% 72.38%
=======================================
Files 3 3
Lines 134 134
=======================================
Hits 97 97
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@eduardo-rodrigues @ariostas |
|
Please let me know if the test file titles need another update. |
ariostas
left a comment
There was a problem hiding this comment.
Thank you, @sathabbott! Looks good to me. If @eduardo-rodrigues has no further comments I can merge it and make a release.
|
Hi. Sounds good, thanks to @ariostas's feedback. We're always happy to learn that this test data package is useful outside Scikit-HEP :). |
|
[@ariostas, do not forget to add @sathabbott to the list of contributors, https://github.com/scikit-hep/scikit-hep-testdata?tab=readme-ov-file#contributors. And it seems other people from recent PRs didn't make it to the list either ... and you didn't either, which is odd ;-)!] |
|
Oh that's a good point! @all-contributors please add @sathabbott for data |
|
I've put up a pull request to add @sathabbott! 🎉 |
|
Thank you both! |
Adding test data root files from rntviewer.