feat: add RNTuple with inherited structs #216
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 72.51% 72.51%
=======================================
Files 4 4
Lines 131 131
=======================================
Hits 95 95
Misses 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you, @mrzimu! To keep it consistent with the rest of the RNTuples here, let's name it something like Also, I'm wondering if there's some way to keep it all in a single file. The dictionary generation can't be done within the same file? |
I will name it as I also tend to keep it all in a single file, but I couldn't find a way to generate the dictionary properly now. Let me look into it. |
|
Thanks @mrzimu! Last thing, could you rename the actual root file? |
I have renamed it |
Oh sorry, I forgot that generated file... |
|
Maybe it was only renamed locally, and you forgot to push it. But I went ahead and renamed it, so no worries. Thanks again! (I'll do a couple checks before merging) |
|
@all-contributors please add @mrzimu for data |
|
I've put up a pull request to add @mrzimu! 🎉 |
Hi,
As requested by @ariostas, I have added a file to test the reading of RNTuples containing inherited structs, for Uproot's PR scikit-hep/uproot5#1589.
Since writing a derived class requires the dictionary of not only itself but also all its base classes, I added a small CMake project (instead of a simple ROOT script) to properly handle the dictionary generation and avoid cluttering the directory.
Please let me know if anything needs improvement :)