Skip to content

Conversation

pfackeldey
Copy link
Collaborator

Dropping python 3.8, it's EOL.

@pfackeldey
Copy link
Collaborator Author

I checked that the Disassemble check also works already for python 3.10. But I assume we want to keep it the lowest supported python version? Otherwise we might consider bumping it already to 3.10 to buy a bit more time until this has to be addressed again, what do you think @Saransh-cpp ?

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying here:

We have 3.8 in CI mostly because of #531. I haven't had the time to look at it yet, but I guess we can keep running 3.8 in the CI and think about it once it can no longer be accessed in GH Actions.


I checked that the Disassemble check also works already for python 3.10.

Unfortunately, it does not :(

The CI just skips all of the checks as uncompyle6 does not support Python >3.8 -

SKIPPED [2404] tests/test_compute_features.py:101: Unsupported Python version 3.9 (canonic 3.9.0beta5)

@pfackeldey
Copy link
Collaborator Author

ah, my fault!! hm, ok, then we need to rethink this :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants