Skip to content

Fix bug # 406 which does not support categorical variables #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bug # 406 which does not support categorical variables #434

wants to merge 2 commits into from

Conversation

salmuz
Copy link

@salmuz salmuz commented Apr 18, 2024

Description

It fix the bug reported in #406

Fixes #406

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@salmuz salmuz changed the title Fix bug https://github.com/scikit-learn-contrib/MAPIE/issues/406 Fix bug # 406 which does not support categorical variables Apr 18, 2024
@LacombeLouis
Copy link
Collaborator

Hey @salmuz,
The PR looks good.
I think we're encountering a typing error. Tell us if you struggle fixing the issue!
Looking forward to merge the PR!

@LacombeLouis
Copy link
Collaborator

Hey @salmuz
Thank you for this PR! For the moment it doesn't pass some tests, but we have fixed the issue. So you can git merge upstream/main and everything should work!
Thank you!

@github-actions github-actions bot mentioned this pull request Jun 24, 2024
Open
@Valentin-Laurent
Copy link
Collaborator

Hello @salmuz, are you still working on this PR?
Happy to help

@Valentin-Laurent Valentin-Laurent added the PR - Work in progress (contributor) A contributor is working on it. label Jan 13, 2025
@Valentin-Laurent Valentin-Laurent added Contributors welcome 👋🏻 Especially relevant issue/PR for contributors to work on. PR - Backlog The MAPIE team will resume this PR. and removed PR - Work in progress (contributor) A contributor is working on it. labels Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LacombeLouis LacombeLouis Awaiting requested review from LacombeLouis

@thibaultcordier thibaultcordier Awaiting requested review from thibaultcordier

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Contributors welcome 👋🏻 Especially relevant issue/PR for contributors to work on. PR - Backlog The MAPIE team will resume this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does MAPIE Regressor support categorical variables?
3 participants
@salmuz @LacombeLouis @Valentin-Laurent