Skip to content

Adding Kernel PCovC Code #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 76 commits into from
Closed

Adding Kernel PCovC Code #251

wants to merge 76 commits into from

Conversation

@rvasav26
Copy link
Collaborator

@rvasav26 rvasav26 commented Jun 4, 2025 •
edited
Loading

Adding Kernel PCovC code and testing suite. Adding a KPCov base class that both Kernel PCovR and Kernel PCovC inherit from.

Contributor (creator of PR) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

For Reviewer

  • CHANGELOG updated if important change?

📚 Documentation preview 📚: https://scikit-matter--251.org.readthedocs.build/en/251/

rvasav26 and others added 30 commits April 10, 2025 12:27
@rvasav26
Adding PCovC code
93be99a
@rvasav26
Merge remote-tracking branch 'upstream/main'
cb9dba8
@rvasav26
Changing check_lr_fit to check_cl_fit and updating respective tests.
ead6516
@rvasav26
Adding KPCovC code, as well as KPCovC tests.
8d00fe6
@rvasav26
Adding PCovC code
427dc8d
@rvasav26
Changing check_lr_fit to check_cl_fit and updating respective tests.
4697039
@rvasav26
Adding KPCovC code, as well as KPCovC tests.
e51ddd7
@rvasav26
Fixing error in pull request
3191c26
@rvasav26
Working on KPCovC
bd21668
@rvasav26
Moving files around
44169bc
@rvasav26
Investigating PCovCSPaceTest errors
96ae408
@rvasav26
Adding _BasePCov class and modifying PCovR and PCovC to implement bas…
1b99d0f 
…e class
@rvasav26
Working on _BasePCov class and changing docstrings for PCovC
ab45da6
@rvasav26
Fixing errors with PCovC self.classifier_
ae1dc0d
@rvasav26
Cleaning up _BasePCov along with new PCovR and PCovC subclasses
1bb0d75
@rvasav26
Working on KPCovC SVC compatibility
5d5dd32
@rvasav26
Working on KPCovC, investigating minor errors
9d784c6
@rvasav26
Fixing decision_function shape for PCovC, writing corresponding Z test
86968dc
@rvasav26
Changing check_cl_fit to check for classifier coefficient mismatches
2e83a57
@rvasav26
Cleaning up documentation, refactoring KPCovC
f1bc971
@rvasav26
Tweaking docstrings for PCovC
206abea
@rvasav26
Renaming files, reworking check for compatible classifiers/regressors
a120baf
@cajchristian @rvasav26
Setting up __init__.py
a42d669
@rvasav26
Minor fix to PCovR after skmatter update with sklearn 1.6
153b815
@cajchristian
Fixing imports
bbd90d0
@rvasav26
Minor sklearn update changes to PCovC, modifying example graphs
6318783
@rvasav26
Cleaning up files, working on fixing KPCovC errors
a030906
@rvasav26
Using validate_data in PCovC/KPCovC for scikit-learn compatibility
0c8fa48
@rvasav26
Fixing formatting for example notebooks
4e0404a
@rvasav26
Modifying decision_function for PCovC/KPCovC
efe6488
rvasav26 and others added 25 commits May 14, 2025 11:55
@rvasav26
Merging adding-pcovc-new branch's updates with adding-kpcovc
21907be
@rvasav26
Minor changes to examples, formatting
f807237
@rvasav26
Fixing docstrings to address docs build errors
c651e23
@rosecers
Fixing whitespace for linter
c0a16aa
@rosecers
Adding pcovc to docs
f66aa9d
@rvasav26
Investigating KPCovC errors
c5c47e5
@rvasav26
Making PCovC accessible via API reference on docs for now.
3995e16
@rvasav26
Merging adding-pcovc-new branch's updates with adding-kpcovc
b3d0e84
@rvasav26
Investigating KPCovC test_linear_matches_pcovc and test_reconstructio…
5267aa6 
…n_errors
@rvasav26
Making PCovC accessible via API reference on docs for now.
df8fa2e
@rvasav26
Modifying docstrings and setting up docs
160790e
@rvasav26
Touching up docstrings
ba9070f
@rvasav26
Implementing Rosy's suggestions to code
f56ea06
@rvasav26
Changing test_kpcovc_error
3de7697
@rvasav26
Merging latest changes from adding-pcovc-new branch
c414699
@rvasav26
Adding KPCovC to docs
2e34f07
@rvasav26
Changing assertTrue to assertEqual for correctness
d28e3bd
@rvasav26
Investigating into KPCovC inconsistencies
43d91e2
@rvasav26
Trying out some things for KPCovC problems
9dd8a29
@rvasav26
Changing KPCovC's test_precomputed_classification
c7b70a9
@rvasav26
Continuing KPCovC investigation
8b19a1d
@rvasav26
Changing _BasePCov and _BaseKPCov to be abstract base classes
4ff6377
@rvasav26
Cleaning up print statements
6385512
@rvasav26
Merging PCovC update
02e218a
@rvasav26
Removing KPCovC experiment
480f029
@rvasav26 rvasav26 closed this Jun 8, 2025
@rvasav26 rvasav26 deleted the adding-kpcovc branch June 8, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rvasav26 @cajchristian @rosecers