-
Notifications
You must be signed in to change notification settings - Fork 38
Docstring update for L2 penalty in SparseLogisticRegression #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+15
−7
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4563f22
Altered Quadratic class
0f21cdf
Include ElasticNet like regularization for SparseLogisticRegression
85e26c1
Revert "Altered Quadratic class"
b5b9eef
Resolve merge conflict from PR #244
floriankozikowski 223fd80
Improve docstring: add math objective to SparseLogisticRegression
floriankozikowski 1d75bb2
Add changelog entry for ElasticNet support in SparseLogisticRegression
floriankozikowski a4b66c0
Merge pull request #1 from floriankozikowski/elasticnet
floriankozikowski 18378fb
Remove trailing whitespace to pass linter
floriankozikowski de27031
change docstring to make it lighter
floriankozikowski 2b09027
Update skglm/estimators.py
mathurinm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go without the cdots for lighter formulas; also the squared L2 term should be divided by 2 (check the Enet docstring)