MNT add python version requirement #289
Conversation
My development tools (uv) were complaining about the missing `requires-python` field in `pyproject.toml`. This adds a dependency on at least 3.11, which is what scipy and numpy currently demands.
pyproject.toml
Outdated
| ] | ||
| dynamic = ["version"] | ||
|
|
||
| requires-python = ">=3.8" |
There was a problem hiding this comment.
scikit-learn requires at least 3.9 (e.g classifier)
I don't know to which extent skglm would work with lower version
There was a problem hiding this comment.
3.8 has reached its EOL 6 months ago so go for 3.9 !
There was a problem hiding this comment.
Seems reasonable. I originally set this to 3.11 actually, but then saw this:
ERROR: Package 'skglm' requires a different Python: 3.8.1 not in '>=3.9'
in the circle CI test logs, so I figured you needed 3.8. But the error still remains so I guess it's something different.
Scipy and numpy both require at least 3.11 now, numba 3.10.
There was a problem hiding this comment.
I just bumped the version of Python used in our circleci workflow to 3.10 instead
|
@Badr-MOUFAD pytest fails because of something that we should fix, merge if OK for you |
Badr-MOUFAD
left a comment
Badr-MOUFAD
left a comment
There was a problem hiding this comment.
It doesn't hurt us to update this
skglm/.github/workflows/flake8.yml
Line 23 in 6309a6a
Only needed for code format checks.
LGTM, thnx @jolars @mathurinm 💪
Co-authored-by: mathurinm <[email protected]>
Co-authored-by: mathurinm <[email protected]>
3 participants
Context of the PR
The
requires-pythonfield inpyproject.tomlis missing.Contributions of the PR
So this PR pins the python version and adds a couple of classifiers related to it for pypi.
Checks before merging PR
[ ] added documentation for any new feature[ ] added unit tests[ ] edited the what's new (if applicable)