Skip to content

MNT add python version requirement #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2025
Merged

MNT add python version requirement #289

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc7ac99
MNT add python version requirement
jolars Apr 10, 2025
2e76d1e
fixup! MNT add python version requirement
jolars Apr 10, 2025
2823746
Apply suggestions from code review
mathurinm Apr 10, 2025
9bf706a
bump python version
mathurinm Apr 10, 2025
77cec39
xvfb
mathurinm Apr 10, 2025
26397cc
indent
mathurinm Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,17 @@ dependencies = [
]
dynamic = ["version"]

requires-python = ">=3.8"
Copy link
Collaborator

@Badr-MOUFAD Badr-MOUFAD Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scikit-learn requires at least 3.9 (e.g classifier)
I don't know to which extent skglm would work with lower version

Copy link
Collaborator

@mathurinm mathurinm Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.8 has reached its EOL 6 months ago so go for 3.9 !

Copy link
Contributor Author

@jolars jolars Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. I originally set this to 3.11 actually, but then saw this:

ERROR: Package 'skglm' requires a different Python: 3.8.1 not in '>=3.9'

in the circle CI test logs, so I figured you needed 3.8. But the error still remains so I guess it's something different.

Scipy and numpy both require at least 3.11 now, numba 3.10.

Copy link
Collaborator

@mathurinm mathurinm Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just bumped the version of Python used in our circleci workflow to 3.10 instead


classifiers = [
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
]

[tool.setuptools.dynamic]
version = {attr = "skglm.__version__"}
Expand Down