ENH Add SLOPE penalty #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Badr MOUFAD <[email protected]>
|
What do you think of adding https://github.com/jolars/pyslope as a test dependecy for SLOPE and test that we find the same solution ? |
I think it's a good idea. Then we can have a "true" test |
Badr-MOUFAD
reviewed
Oct 27, 2022
Badr-MOUFAD
reviewed
Nov 2, 2022
Co-authored-by: Badr MOUFAD <[email protected]>
mathurinm
approved these changes
Nov 2, 2022
|
merge when green |
Badr-MOUFAD
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC of the SLOPE penalty with FISTA solver. We should first merge #91 before this one.