✨ stats: improve zscore and gzscore
#816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves type annotations for the zscore and gzscore functions in the scipy stats module by adding comprehensive overloads that provide more precise return types based on input array types and shapes.
- Enhanced type annotations with detailed overloads for different input types (integer, float, complex) and array dimensions
- Added comprehensive test coverage for the new type annotations
- Minor cleanup of axis parameter types in the
lmomentfunction
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
scipy-stubs/stats/_stats_py.pyi |
Added detailed overloads for zscore and gzscore functions with precise return types, and simplified lmoment axis parameter types |
tests/stats/test_zscore.pyi |
Added comprehensive type tests covering various input types and array dimensions for the improved zscore function |
jorenham
force-pushed
the
better-stats.zscore
branch
from
9a56255 to
0fb2e32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #572