[Fileservice] Multi-file download single RACM call for permissions#103
Open
amitschang wants to merge 2 commits intomainfrom
Open
[Fileservice] Multi-file download single RACM call for permissions#103amitschang wants to merge 2 commits intomainfrom
amitschang wants to merge 2 commits intomainfrom
Conversation
amitschang
changed the title
Contributor
|
Reviewing it |
Contributor
|
Fireeeee YESSSSSSS ❤️🔥 |
peppermint-juli
approved these changes
Apr 20, 2026
Contributor
peppermint-juli
left a comment
peppermint-juli
left a comment
There was a problem hiding this comment.
Fireeeeeee YEEEEESSSSSS ❤️🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements permission check specifically for the multiple file download endpoint in order to make only a single request to racm, instead of a request per file. It does so by using the get volumes endpoint to describe all the users volume access into memory, and then check files against this. Essentially it implements the
generalCheckagainst theFileServiceModel(the same which is returned by the/volumesendpoint).This should make a substantial improvement to the datasets page load time.
Testing: I have deployed to a dev install and confirmed that the datasets page loads index files as expected, can see the corresponding racm
getDetailsOfFileServicerequestResolves #57