Skip to content

add subpath spec for volume claim mounts #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitschang merged 2 commits into from
Mar 26, 2026
Merged

add subpath spec for volume claim mounts #97

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
153cc30
add subpath spec for volume claim mounts
amitschang Mar 20, 2026
9a92d30
Merge branch 'main' into pvc-subpath-fix
amitschang Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions helm/sciserver/templates/fileservice/fileservice-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ spec:
{{- range $key, $val := .Values.fileservice.pvcVolumes }}
- name: {{ $key }}
mountPath: {{ $val.mountPath }}
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chart now supports .Values.fileservice.pvcVolumes[*].subPath, but the values.yaml example/comment block for fileservice.pvcVolumes doesn’t mention this field. Please update the chart’s values documentation (e.g., helm/sciserver/values.yaml and any user docs) to include subPath, so operators can discover/configure it correctly.

Suggested change
mountPath: {{ $val.mountPath }}
mountPath: {{ $val.mountPath }}
{{- /* Optional: set .Values.fileservice.pvcVolumes[<name>].subPath to mount a sub-directory of the PVC */ -}}

Copilot uses AI. Check for mistakes.
{{- if $val.subPath }}
subPath: {{ $val.subPath }}
{{- end }}
{{- end }}
livenessProbe:
timeoutSeconds: 5
Expand Down
Loading