-
Notifications
You must be signed in to change notification settings - Fork 290
Removing langchain.js from testing suite due to yarn is necessary for installation #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[test-upstream] |
Testing Farm results
|
|
Test failed for this reason for Version 20: for test_client_fastify: for pino |
|
@pacostas Please address issues in this Pull request as well. |
|
@phracek I'm not able to reproduce that locally by using the following commands Do you know if that is the closest environment that someone can have locally for testing the node modules? |
|
@phracek This issues are not related to the PR changes. Also fastify and pino do not fail on the nodejs upstream nightly builds. Can you please re-trigger the tests? |
Removing langchain.js from the testing suite.
This PR removes
langchain.jsfrom the testing suite because the yarn binary isn't available on the base images.Until we further investigate how to properly include and install the yarn binary on the base images to test the
langchain.jslibrary, it's better to removelangchain.js. Currently, the failing test is a false alarm indication, asLangchainitself is not failing.