Skip to content

Removing langchain.js from testing suite due to yarn is necessary for installation #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pacostas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removing langchain.js from testing suite due to yarn is necessary for installation #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions test/run-upstream
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ test_client_faas
test_client_cloudevents
test_client_fastify
test_client_pino
test_client_langchainjs
"

TEST_LIST_BINARY="\
Expand All @@ -49,8 +48,6 @@ readonly CLOUDEVENTS_REVISION="v${CLOUDEVENTS_REVISION:-$(docker run --rm "${IMA
readonly CLOUDEVENTS_REPO="https://github.com/cloudevents/sdk-javascript.git"
readonly FASTIFY_REVISION="v${FASTIFY_REVISION:-$(docker run --rm "${IMAGE_NAME}" -- npm show fastify version)}"
readonly FASTIFY_REPO="https://github.com/fastify/fastify.git"
readonly LANGCHAINJS_REVISION="${LANGCHAINJS_REVISION:-$(docker run --rm "${IMAGE_NAME}" -- npm show langchain version)}"
readonly LANGCHAINJS_REPO="https://github.com/langchain-ai/langchainjs.git"

# Since we built the candidate image locally, we don't want S2I attempt to pull
# it from a registry
Expand Down
5 changes: 0 additions & 5 deletions test/test-lib-nodejs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,11 +444,6 @@ function test_client_cloudevents() {
test_running_client_js cloudevents
}

function test_client_langchainjs() {
echo "Running langchainjs client test"
test_running_client_js langchainjs
}

function test_client_fastify() {
if [[ "${VERSION}" == *"minimal"* ]]; then
VERSION=$(echo "${VERSION}" | cut -d "-" -f 1)
Expand Down