Support PyTest container test suite for Python Container. #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phracek
added a commit
to phracek/s2i-python-container
that referenced
this pull request
Nov 11, 2025
This blocks: sclorg#768 Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
added a commit
that referenced
this pull request
Nov 11, 2025
This blocks: #768 Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
container_pytests
branch
from
5866b10 to
cf7da90
Compare
Member
Author
|
Rebased against master. Let's run first round of tests. |
Testing Farm results
|
Member
Author
|
RHEL8 failures are caused by CDN errors: |
phracek
force-pushed
the
container_pytests
branch
from
6a695bd to
e2004a5
Compare
Member
Author
|
[test][test-all] |
Member
Author
|
The new container-ci-suite was released. Let's re-test it. [test-all] |
Member
Author
|
Python failures are: C10S - PyTest - 3.12-minimal: It caused, I guess, main image should not be pulled. C10S - 3.12 should not be exists in quay.io/sclorg/python-312-c10s. RHEL10 does not exists. Fedora PyTest - 3.13 - test_container_basics.py::TestS2IPythonContainer::test_dockerfiles[Dockerfile.tpl] INFO:Image name to test: quay.io/fedora/python3-313:3.13 RHEL8 - 3.11 and RHEL9-PyTest-3.11 |
Member
I don't understand this sentence, sorry. We have dockerfiles here for 3.12 and 3.12-minimal based on C10S.
The version of psycopg2-binary I see in the logs indicates that this test used django-ex branch 3.2.x and that's incorrect. New Pythons like 3.13 should use Django version/branch 4.2.x that has newer psycopg2-binary dependency and that new version provides wheels for Python 3.13.
I need more time to investigate the last one. I'm not able to reproduce locally so I need to build the container image first. |
Also VARS.* variables are used during the migration. Signed-off-by: Petr "Stone" Hracek <[email protected]>
Migration matrix is: `build_s2i_app` is fixture that takes `Path` test-app from `conftest.py` file. test_container_application.py tests all test-app directories. test_container_basics.py tests only basics w/o application. It also tests test_dockerfile and test_minimal_dockerfile Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Add distgen generated files Signed-off-by: Petr "Stone" Hracek <[email protected]>
Fix proper branch in `test_dockerfiles` function. Add test suite to Class and build application once. Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
container_pytests
branch
from
e2004a5 to
df1b3e2
Compare
Member
Author
|
I have fixed some issues. Let's re-run tests again |
Member
frenzymadness
left a comment
frenzymadness
left a comment
There was a problem hiding this comment.
It looks good overall. Just a few nitpicks.
| image_name=full_image_name, loops=1 | ||
| ) | ||
| print(f"Is image {full_image_name} pulled? {is_pulled}") | ||
| if is_pulled: |
Member
There was a problem hiding this comment.
Shouldn't this part just fail when we are unable to pull the full image and therefore run the tests?
Member
Author
There was a problem hiding this comment.
See here: https://github.com/sclorg/s2i-python-container/blob/master/test/run#L236. In case it is not pull, then skip the tests.
Member
Author
There was a problem hiding this comment.
The problem in bash suite is here:
$ IMAGE_NAME=quay.io/sclorg/python-39-minimal-c9s:39-minimal
$ NEW_IMAGE=${IMAGE_NAME/-minimal/}
$ echo $NEW_IMAGE
quay.io/sclorg/python-39-c9s:39-minimal
$
which is totally different image.
Member
Author
There was a problem hiding this comment.
@frenzymadness What about if full version does not exist? Like python-312-minimal for RHEL10? It should not fail, I guess.
Member
There was a problem hiding this comment.
Thanks for the explanation, that makes sense. Could you please improve the message to something like: The full container image for the minimal one does not exist, skipping the rest of the tests.
Member
|
Let me know if you want me to take a look at the results of the failed tests. |
Use default branch 4.2.X for all versions except 3.6 Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
Let's test it again [test-pytest] |
minimal one does not have it. Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
[test-pytest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request migrates bash test suite
to container-ci-suite stored here: https://github.org/sclorg/container-ci-suite
Introduce PyTest suite migrated from test/run bash suite.
Migration matrix is:
build_s2i_appis fixture that takesPathtest-app fromconftest.pyfile.
test_container_application.py tests all test-app directories.
test_container_basics.py tests only basics w/o application.
It also tests test_dockerfile and test_minimal_dockerfile
Signed-off-by: Petr "Stone" Hracek [email protected]