Skip to content

Conversation

@pfeuffer
Copy link
Member

@pfeuffer pfeuffer commented Nov 8, 2021

Proposed changes

If EnvelopeBuilderImpl#fromCurrentUser() is used, this used the mail
address of the current user, if present.

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • New code is covered with unit tests
  • Changelog entry file created in gradle/changelog or CHANGELOG.md is updated for plugins

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

If EnvelopeBuilderImpl#fromCurrentUser() is used, this used the mail
address of the current user, if present.
@pfeuffer pfeuffer force-pushed the bugfix/from_address_for_current_user branch from 49977c0 to 8deb5c4 Compare November 8, 2021 13:12
@pfeuffer pfeuffer marked this pull request as ready for review November 8, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants