Skip to content

refactor(scp): factorize common codes #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2025
Merged

Conversation

akinomyoga
Copy link
Collaborator

This is another PR separated from #1357. This commit is just trivial refactoring, but the next commit is nontrivial. I decided to submit this single commit before submitting the rest.

@akinomyoga
Copy link
Collaborator Author

I realized that fe7a3f9 is a related commit, which was added after @yedayak's comment at #1357 (comment), so I pushed the commit. If a fixed positional argument is preferred, the commit can be dropped. Otherwise, this extra commit can finally be squashed at the merging time.

Copy link
Owner

@scop scop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the -d-as-option approach, let's keep it. A couple of suggestions for another followup commit, pre-approved with or without it added.

@akinomyoga
Copy link
Collaborator Author

I applied the door changes. I also squashed the second commit (the change for the -d command-line flag) into the first commit, while rebasing the PR on top of the latest main branch.

@akinomyoga akinomyoga merged commit c55ee7f into scop:main Aug 10, 2025
7 checks passed
@akinomyoga akinomyoga deleted the scp-refactor-2 branch August 10, 2025 11:28
@akinomyoga
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants