fix(java,rsync,scp): handle quoted space in filepaths properly #1417
Merged
akinomyoga merged 2 commits intoscop:mainfrom Sep 18, 2025
Merged
fix(java,rsync,scp): handle quoted space in filepaths properly #1417akinomyoga merged 2 commits intoscop:mainfrom
akinomyoga merged 2 commits intoscop:mainfrom
Conversation
Filenames containing a special character are not properly completed [1]. These completions generate filenames by pathname expanaion using $cur. However, $cur contains the word on the command line including quotaing, such as cur='file\ with\ space.txt' and cur='"a b c.txt"'. This patch obtains the value of "cur" using _comp_dequote. [1] scop#1232 This patch also fixes a similar case in completions/java. Co-authored-by: Yedaya Katsman <yedaya.ka@gmail.com>
yedayak
approved these changes
Sep 10, 2025
akinomyoga
force-pushed
the
scp-refactor-3
branch
from
badc247 to
2f4f10b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated from #1357.
Fixes #1232