feat: add gcp-pubsub-emulator provisioner for score-compose#54
feat: add gcp-pubsub-emulator provisioner for score-compose#54mathieu-benoit merged 3 commits intoscore-spec:mainfrom
Conversation
Add Google Cloud Pub/Sub Emulator provisioner for local development. Resource type: gcp-pubsub-emulator Params: project_id (optional) Outputs: host, port, project_id, emulator_host Image: gcr.io/google.com/cloudsdktool/google-cloud-cli:emulators Closes score-spec#53 Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR adds a Google Cloud Pub/Sub Emulator provisioner for local development and testing with score-compose. The provisioner spins up a GCP Pub/Sub emulator container using the official Google Cloud SDK emulator image.
Changes:
- Added provisioner file with support for optional
project_idparameter and outputs forhost,port,project_id, andemulator_host - Added example Score workload demonstrating usage with busybox container
- Updated README to document the new provisioner in the score-compose table
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gcp-pubsub-emulator/score.yaml | Example workload demonstrating how to consume the GCP Pub/Sub emulator resource |
| gcp-pubsub-emulator/score-compose/10-gcp-pubsub-emulator.provisioners.yaml | Provisioner definition for the GCP Pub/Sub emulator service |
| README.md | Added table entry documenting the new provisioner |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Dear @mathieu-benoit , |
|
Thanks @thc1006, I'll do my review over the weekend, thanks for your contribution, much appreciated! |
- Change Chinese comment to English in provisioner file - Add params section with project_id example in score.yaml - Demonstrate all 4 outputs (host, port, project_id, emulator_host) Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Would you suggest I add a
|
There was a problem hiding this comment.
LGTM, thanks for this implementation and the detailed documentation, much appreciated!
For your question about healthcheck, good point and good practice, but not sure there is any in there https://github.com/GoogleCloudPlatform/cloud-sdk-docker/tree/master/emulators.
Summary
Add Google Cloud Pub/Sub Emulator provisioner for local development and testing.
gcp-pubsub-emulatorscore-composeonly (score-k8s deferred to future PR)project_id(optional)host,port,project_id,emulator_hostgcr.io/google.com/cloudsdktool/google-cloud-cli:emulatorsChanges
gcp-pubsub-emulator/score.yaml- Example workloadgcp-pubsub-emulator/score-compose/10-gcp-pubsub-emulator.provisioners.yaml- ProvisionerREADME.md- Added provisioner entry to score-compose tableTest
Closes #53